Fix SSO dataset error on site wide org#1721
Open
vaimdevs wants to merge 3 commits into
Open
Conversation
vaimdevs
commented
Jul 10, 2026
Contributor
…false success switch_org() treated any status=='OK' response as a completed switch, but the server overloads that status for two different outcomes: a real switch (data has pk/org_name/organization_slug) and an SSO re-authentication challenge (data['idp'] populated) for members of SSO-protected orgs who aren't the owner/admin. The challenge case never actually updates the server-side active org, so treating it as success silently left callers on their previous org while locally claiming to have switched. Now raises with the idp names and a pointer to sso_login(org_name=...) as the alternative, instead of logging a false "Switched to organization" and setting self.session.org_name to a value the server never accepted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.